-
Notifications
You must be signed in to change notification settings - Fork 18
Fix button focus on firefox tu use native focus #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves custom Firefox-specific button focus outlines so that Firefox uses its native focus styles for buttons, aligning button focus behavior with the rest of the application for better accessibility and consistency. Flow diagram for Firefox button focus styling decisionflowchart TD
A[Button_in_Firefox_receives_focus] --> B{Browser_applies_focus_style}
B --> C[Native_Firefox_focus_style]
subgraph Previous_behavior
D[Normalize_SCSS] --> E[Firefox_specific_rule
outline 1px dotted ButtonText]
A --> D
E -.overrides.-> C
end
subgraph New_behavior
F[Removed_Firefox_specific_focus_rule]
A --> G[No_custom_outline_for_Firefox]
G --> C
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since this change intentionally relies on the native Firefox focus outline, consider adding a short comment in
_normalize.scssnear the removed rule to document the accessibility rationale and avoid future reintroduction of custom outlines.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this change intentionally relies on the native Firefox focus outline, consider adding a short comment in `_normalize.scss` near the removed rule to document the accessibility rationale and avoid future reintroduction of custom outlines.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
MarieComet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lezgo
Suite à un retour de Temesis, les focus des boutons sur fixefox sont dégradés et pas assez épais en vue de la MAJ du RGAA incluant WCAG 2.2.
On garde le focus natif navigateur comme c'est déjà le cas pour tout le reste
Summary by Sourcery
Bug Fixes: